Fix docker_appdir path in omeroweb CreateApp.rst #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@will-moore I directly pushed a commit removing the remaining python2.7 on that page |
joshmoore
reviewed
Jun 24, 2020
| @@ -83,7 +83,7 @@ python can import our ``minimal_webapp`` module. | |||
| $ appdir=$(pwd)/minimal-webapp/minimal_webapp | |||
|
|
|||
| # Location within Docker instance we want to link the app, so it can be imported. | |||
| $ docker_appdir=/opt/omero/web/venv/lib/python2.7/site-packages/minimal_webapp | |||
| $ docker_appdir=/opt/omero/web/venv3/lib/python3.6/site-packages/minimal_webapp | |||
There was a problem hiding this comment.
Not that it need beed done in this PR, but @manics, is there anything that could be done in the omero-web(-standalone) app to make this registration easier? A symlink from /apps? A .pth file? etc.
There was a problem hiding this comment.
Does -e PYTHONPATH=/mountpoint work?
There was a problem hiding this comment.
If I set $appdir so that
$ echo $appdir
/Users/wmoore/Desktop/WEB-APP-EXAMPLES/omero-web-apps-examples/minimal-webapp/
This allows me to import the app locally:
$ export PYTHONPATH=$appdir
$ python
>>> import minimal_webapp
But this doesn't work:
$ docker run -it --rm -e OMEROHOST=$host -p 4080:4080 -e PYTHONPATH=$appdir -v $config:$docker_config openmicroscopy/omero-web-standalone
...
ModuleNotFoundError: No module named 'minimal_webapp'
There was a problem hiding this comment.
You'll still need to mount it inside the docker image. E.g.
appdir=$PWD/omero-metadata/src
docker run -it --rm ... -e PYTHONPATH=/apps -v $appdir:/apps --name test openmicroscopy/omero-web-standalone
$ docker exec -it test python -c 'import omero_metadata; print(omero_metadata.__file__)'
/apps/omero_metadata/__init__.pyc
There was a problem hiding this comment.
Created #2140 to look into this - but not essential for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.image.sc/t/enable-fpbioimage-in-omeroweb-docker/39361/3?u=will-moore
Fix path to docker_appdir with py3.6.