Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centos7 #2436

Merged
merged 8 commits into from
Jul 5, 2024
Merged

Centos7 #2436

merged 8 commits into from
Jul 5, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Jul 3, 2024

  • Remove installation instructions for centOS 7

@jburel jburel requested a review from sbesson July 3, 2024 12:53
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping these installation pages completely makes sense. https://omero.readthedocs.io/en/stable/sysadmins/version-requirements.html#linux-centos-and-rhel should probably also be updated to mark CentOS/RHEL 7 as officially unsupported?

@jburel
Copy link
Member Author

jburel commented Jul 3, 2024

Related PRs ome/omero-install#288 and ome/omeroweb-install#96

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the only other place that has a clear reference to CentOS 7 as a target system that I could find is https://omero--2436.org.readthedocs.build/en/2436/sysadmins/python3-migration.html#choosing-a-platform.

I can see two routes here:

  • either treat this page as historical and let it reflect the state of systems as of the Python 3 migration 4+ years ago
  • or do a minimal update to the first paragraph pointing to the version requirements page for details on which operating system/Python version to migrate to

@jburel
Copy link
Member Author

jburel commented Jul 4, 2024

Thanks for pointing that out.
If we treat as historical, we minimally need a warning
I will read it and see if adjusting makes more sense

omero/sysadmins/python3-migration.rst Outdated Show resolved Hide resolved
Debian 9 is still on Python 3.5 and Debian 10 has moved to Ice 3.7.
We have nonetheless an installation guide for Debian 9 with Python 3.5 and Ice 3.6
but an installation guide for Debian 10 with Python 3.7 and Ice 3.6.
Debian 10 has moved to Ice 3.7 but an installation guide for Debian 10 with Python 3.7 and Ice 3.6.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is lacking a verb

Copy link
Member Author

@jburel jburel Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove Debian 10 in a follow-up PR since it has also reached EOL (30/06)

@jburel jburel merged commit 3fd738e into ome:develop Jul 5, 2024
1 check passed
@jburel jburel deleted the centos7 branch July 10, 2024 09:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants