-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django: link to 4.2 documentatoin #2476
Conversation
Also cull links to obsolete Django versions
Conflicting PR. Removed from build OMERO-docs#338. See the console output for more details.
|
Changes look good. Tried running the build job to check at https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-docs/338/artifact/ but conflict prevented inclusion. |
bb89a34
to
f66851a
Compare
Thanks, this is conflicting with #2473 which is also modifying both configuration files. To ease the review and integration process, I have pushed bb89a34 away and limited the scope to the Django 4.2 documentation link. The removal of the superfluous (?) configuration file can be assessed separately. |
Re-ran the build, which failed on "ajax". I guess that term is a little dated now!
|
Agreed, since it looks like they have split the CSRF documentation between reference and how-to guide. I have updated the AJAX link to point to the latter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build output looks good, Django doc links to 4.2 as expected. https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-docs/340/artifact/
Noticed while writing ome/omero-web#608 (comment), the current OMERO documentation still points at the Django 1.11 documentation.
95080ea updated
common/conf.py
but it looks like this configuration file is either a no-op or overriden byomero/conf.py
.To reduce future confusion, bb89a34 proposes to remove this duplication configuration file.