Dev build #469
Merged
Dev build #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/6 |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/10 |
will-moore
reviewed
Jun 29, 2022
There was a problem hiding this comment.
Looks good.
Might be worth adding the debug / development args from https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/10 which allow you to see changes without needing to restart omero-web or docker.
will-moore
reviewed
Jun 30, 2022
will-moore
reviewed
Jun 30, 2022
will-moore
approved these changes
Jun 30, 2022
|
@will-moore done |
|
Looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the obsolete section about demo
and revisits the dockerfile so figure can be developed into a "omero-web" docker framework
This work was initiated by discussion on https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/5