-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev build #469
Dev build #469
Conversation
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/6 |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Might be worth adding the debug / development args from https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/10 which allow you to see changes without needing to restart omero-web or docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor points, but all working fine 👍
@will-moore done |
Looks good, thanks |
This PR removes the obsolete section about demo
and revisits the dockerfile so figure can be developed into a "omero-web" docker framework
This work was initiated by discussion on https://forum.image.sc/t/docker-build-error-to-test-omero-figure/68624/5