Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roi tiles #242

Closed
wants to merge 56 commits into from
Closed

Roi tiles #242

wants to merge 56 commits into from

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Feb 21, 2019

This uses Tile-based ROIs on single-plane images with > 500 ROIs.
On multi-plane images, if there are more than 500 ROIs on any plane, simple pagination is used.

Instead of the previous strategy #227 of replacing the existing Vector Regions layer with Tiled Regions layer, this tries to use both alongside each other. This means that we can still use the existing Regions layer for editing ROIs we have loaded in the ROI table (as in #231) but we can browse Tiled ROIs on the image.
If you click a Tile-based ROI on the image, it loads the ROI into the Table (and the Vector Regions layer) so you can edit them.

If we wanted to pursue this strategy, other TODOs:

If we requestRois here (when switching images and the ROI tab is active)
then we load ROIs before we know the current Z/T index of the image
and before any cached Z/T settings have been applied.
We don't need to request ROIs here, since the image_info will do
this on success from loading image info if ROIs tab is active
@will-moore
Copy link
Member Author

Showed @jburel the ROI shape counts when zooming out:

screen shot 2019-02-21 at 13 49 54

Discussion:

  • Would be better not to load pages of ROIs into the table since it serves no real purpose (and is slow)
  • Instead, can we edit the shapes that are loaded by tile (or just load those shapes to Regions layer)?
  • The only use of the ROI table currently is:
    • Showing ROIs on other planes (when we are not paginating by Z/T plane) - click to browse to other plane
    • Showing Comments, Lengths, Areas for all Shapes - but not very useful unless we can sort, filter, search etc.
  • A better table for multi-Z/T images would show which planes the ROIs/Shapes are on (in the same way that zooming out
  • Would be nice to have OMERO.parade - like features (filtering and sorting ROIs by various criteria)

@will-moore
Copy link
Member Author

Current status: for single-plane images with > 500 ROIs, we don't load ROIs in ROI table but instead load them via Tiles (TiledRegions layer) on the image. When a shape is clicked on the image, it is transferred to the Vector Regions layer for editing, and also it shows up in the ROI table. You can then edit and Save the shape, and draw new shapes:

screen shot 2019-02-25 at 14 02 24

@jburel jburel mentioned this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant