Rois sorted #264
Merged
Rois sorted #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status of this PR? still WIP? |
|
I think this is ready to test. I'll list it for testing... |
|
It is now possible to sort by Z/T and comment |
|
Now we support sorting by Area & Length:
|
|
Works as expected. Ready to merge FMPOV |
jburel
reviewed
Aug 8, 2019
src/regions/regions-list.js
Outdated
| @@ -117,6 +124,17 @@ export default class RegionsList extends EventSubscriber { | |||
| this.waitForRegionsInfoReady(); | |||
| } | |||
|
|
|||
| sort(value) { | |||
| console.log('click Sort', value); | |||
|
Merging travis is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/XZRTvaFj/9-sorting-of-rois-in-table
Allows sorting of ROIs in the table. Work in Progress
When sorting ROIs by an attribute of Shape (e.g. label, theZ, theT etc) it's possible for an ROI to have many shapes. In this case, we pick the first shape!