Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autoPan for shape popup #276

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Aug 22, 2019

This fixes a minor bug where the image pans when drawing shapes because of the popup appearing for a new shape. The shape popup should never cause the image to Pan.
To test:

  • Select to draw a Shape E.g. Polygon
  • Click on the image near the top of the viewport to start drawing
  • The shape popup will appear and track the Polygon as you draw it, but it should not cause the image to pan. NB: this was noticeably worse when using Shift-draw to draw freehand.
  • Also, clicking to select existing shapes when they are close to the edge of the viewport should also not cause the image to pan.
  • In multi-viewer mode, popups and tooltip should work properly on both viewers.

@pwalczysko
Copy link
Member

Works as expected. Ready to merge FMPOV

@jburel jburel merged commit fb66084 into ome:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants