Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show hide shapes in ROI #278

Merged
merged 4 commits into from
Sep 16, 2019
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Sep 8, 2019

See https://trello.com/c/DtbhtoAA/81-show-hide-all-shapes-in-an-roi
from https://forum.image.sc/t/large-mask-roi-on-large-image/29200/7

To test:

  • Find an image with multiple Shapes per ROI (or create in Insight)
  • Check ROI checkbox to show/hide all shapes in the ROI
  • Toggling individual Shape visibility should 'check' the ROI checkbox if All shapes in the ROI are checked (same behaviour as the "Show" checkbox at the top of the table).
  • The "Show" checkbox at the top of the table should also continue to work as expected.

@will-moore will-moore changed the title Click ROI checkbox to toggle ALL shapes visibility show hide shapes in ROI Sep 9, 2019
@mtbc
Copy link
Member

mtbc commented Sep 10, 2019

Seems odd to me that when I first go to the ROI tab for multi-shape ROIs the "show"s for the shapes are all checked but the "show" for their ROI isn't. (If I uncheck a shape then check it again then the ROI is then checked too.)

@mtbc
Copy link
Member

mtbc commented Sep 10, 2019

Otherwise seems to be working well for me!

@will-moore
Copy link
Member Author

#278 (comment) should be fixed (ROI checkbox is initially checked)

@jburel jburel merged commit 8900dae into ome:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants