Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate all tests #122

Merged
merged 10 commits into from
Nov 27, 2019
Merged

Activate all tests #122

merged 10 commits into from
Nov 27, 2019

Conversation

joshmoore
Copy link
Member

Remaining failing tests will need to be marked with "broken"
(or alternatively, "skip").

Remaining failing tests will need to be marked with "broken"
(or alternatively, "skip").
@joshmoore
Copy link
Member Author

         - test/unit/test_rtypes.py:468 TestModel.testMoreConversions[data2]
         - test/unit/tablestest/test_hdfstorage.py:307 TestHdfList.testLocking
         - test/unit/tablestest/test_hdfstorage.py:210 TestHdfStorage.testGetSetMetaMap

@joshmoore
Copy link
Member Author

Python 3 now green. List on Python 2 is longer:

         - test/unit/test_rtypes.py:278 TestModel.testPassThroughNoneAndRTypes
         - test/unit/test_rtypes.py:262 TestModel.testGetAttrWorks
         - test/unit/test_rtypes.py:362 TestModel.testUnwrap
         - test/unit/test_rtypes.py:57 TestModel.testObjectCreationEqualsAndHash
         - test/unit/tablestest/test_servants.py:269 TestTables.testTablesIGetDirGetsRepoThenNoSF
         - test/unit/tablestest/test_servants.py:275 TestTables.testTablesIGetDirGetsRepoGetsSFCantFindRepoFile
         - test/unit/tablestest/test_servants.py:279 TestTables.testTablesIGetDirGetsRepoGetsSFCantFindRepoObject
         - test/unit/tablestest/test_servants.py:290 TestTables.testTables
         - test/unit/tablestest/test_servants.py:322 TestTables.testTablePreInitialized
         - test/unit/tablestest/test_servants.py:333 TestTables.testTableModifications
         - test/unit/tablestest/test_servants.py:285 TestTables.testTablesIGetDirGetsRepoGetsSFGetsRepo
         - test/unit/tablestest/test_servants.py:343 TestTables.testTableAddData
         - test/unit/tablestest/test_servants.py:370 TestTables.testErrorInStorage
         - test/unit/tablestest/test_servants.py:384 TestTables.testErrorInGet
         - test/unit/tablestest/test_servants.py:359 TestTables.testTableSearch
         - test/unit/tablestest/test_servants.py:265 TestTables.testTablesIGetDirNoRepoCreated

@joshmoore
Copy link
Member Author

Green (even on py2 😉)

@sbesson
Copy link
Member

sbesson commented Nov 26, 2019

In terms of coverage, without this PR

========== 1109 passed, 152 skipped, 1 xfailed, 12 warnings in 31.18s ==========

With this PR

Results (45.88s):
    1173 passed
       1 xfailed
     152 skipped

Off-hand I do not see any problem with either commits so proposing to get a final code review and merge once validated by the integration tests.
May I also offer 997c8d0 as an additional cleanup of the pytest warnings?

@joshmoore
Copy link
Member Author

Done and expanded 😄

@sbesson sbesson merged commit 9b5bbad into ome:master Nov 27, 2019
@sbesson
Copy link
Member

sbesson commented Nov 27, 2019

Note the tables unit tests are intermittently failing on Python 3.7 with the tables service returning a null proxy. We might need to selectively xfail/skip this test and come back to it as it probably highlights a 3.7-specific bug

@joshmoore joshmoore added this to the 5.6.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants