-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test covering Unicode #133
Conversation
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
57374ae
to
7020c13
Compare
The numpy.dtype note about using strings in Python 3 is probably relevant to the root of this problem. Unfortunately, local attempts to migrate Earlier demo on IDR upgraded to an experimental Python 3 environment seems to suggest that the reading of I expect I will not be in capacity to provide a fix for this regression for the OMERO 5.6.0. There is a question of whether this should be marked as a blocker for GA, it is certainly one for the upgrade of IDR to Python 3 as it breaks the annotation workflows if CSV files contains Unicode characters. As immediate next steps, proposing to:
Alternate thoughts or suggestions welcome /cc @joshmoore @jburel @manics |
Something I haven't really considered yet: would a |
What would be the difference between a |
It would be a location that could different read/write logic if that would help. |
Superseded by #143 |
See also ome/openmicroscopy#6189
b45e95c exposes a Python 3.6 regression when adding a StringColumn containing Unicode. The same scenario passes without issue on Python 2