Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis jobs: enable Windows #134

Merged
merged 15 commits into from
Jan 30, 2020
Merged

travis jobs: enable Windows #134

merged 15 commits into from
Jan 30, 2020

Conversation

joshmoore
Copy link
Member

Follow on to #132. Run Windows in Travis.

@joshmoore
Copy link
Member Author

All platforms are running (periodically with tables failures) and a real issue with the Windows test arose:

>           return open(string, self._mode)
E           FileNotFoundError: [Errno 2] No such file or directory: 'C:UserstravisAppDataLocalTemppytest-of-unknownpytest-0popen-gw3testLoad0test'

@joshmoore
Copy link
Member Author

Green!

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise looks good

.travis.yml Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member Author

Few commits pushed, @manics.

@manics
Copy link
Member

manics commented Jan 29, 2020

@joshmoore
Copy link
Member Author

That's us back green again, @manics. Not sure why both skips are needed.

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no idea either. skip_cleanup means don't cleanup the earlier build step, but since this is using build stages which are isolated from each other the results of the other stages aren't available so there shouldn't be anything that could be cleaned

@joshmoore
Copy link
Member Author

¯\_(ツ)_/¯ Note: this may have further issues when it comes time to deploy a tag, but I'll deal with that during release.

@joshmoore joshmoore merged commit b4bee53 into ome:master Jan 30, 2020
@joshmoore joshmoore added this to the 5.6.1 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants