Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy to requirements in setup.py #139

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Dec 4, 2019

Required for:

  • BlitzGateway getTile(), createImageFromNumpySeq() etc
  • webgateway: render_shape_mask() logger.error('No numpy installed')

Also required for parade and tests in omero-figure etc (see Travis failure at ome/omero-figure#354).

@will-moore
Copy link
Member Author

Travis failing with:

test/unit/tablestest/test_servants.py:344 TestTables.testTableAddData

    def getHeaders(self, current=None):
>       rv = self.storage.cols(None, current)
E       AttributeError: 'NoneType' object has no attribute 'cols'
.tox/py37/lib/python3.7/site-packages/omero/tables.py:205: AttributeError

And:

test/unit/clitest/test_basics.py:70 TestBasics.testLoadGlob

FATAL: OMERODIR env variable not set

@@ -210,6 +210,7 @@ def read(fname):
'zeroc-ice>=3.6.4,<3.7',
'future',
'Pillow',
'numpy',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: How about keep these in alphabetical order?

@manics
Copy link
Member

manics commented Dec 4, 2019

testLoadGlob should be fixed by #140
The tables error is a transient one.

@joshmoore
Copy link
Member

Now green.

@will-moore
Copy link
Member Author

Good to merge?

will-moore added a commit to will-moore/figure that referenced this pull request Dec 5, 2019
Shouldn't be needed once numpy is required by omero-py in
ome/omero-py#139
will-moore added a commit to will-moore/figure that referenced this pull request Dec 5, 2019
Shouldn't be needed once numpy is required by omero-py in
ome/omero-py#139
@joshmoore
Copy link
Member

WFM

@joshmoore joshmoore merged commit 5866cec into ome:master Dec 5, 2019
@joshmoore joshmoore added this to the 5.6.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants