-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config xml in etc grid #14
Conversation
Travis failing:
|
860d661
to
774f5c4
Compare
Seems OK for now. In future if we move to a new read-only config system (only the administrator can modify the config, omero can't modify itself) we might need a second variable to separate |
Agreed, and/or functionality to prefix those directories with Two questions:
|
Depends on our instructions. If they say you must set Edit: You could also make the case that |
I'm going to exclude for a round of testing on py3-ci. merge-ci passed because it is currently using the versions on pypi. I suspect that this PR is leading to OMERODIR being required such that this takes us into phase 2. If so, a phase 1 version will need to be split out which just creates the directory without changing the lookup logic. |
Confirmed. Without this PR, a devspace (and therefore a user) that has not yet set OMERODIR can start a server. |
@will-moore : could you look at getting this to work under phase 1? |
This is not required for phase 1 with decoupling when we use omero-web as part of the server build (as before). E.g. (without
When we run decoupled omero-py and omero-web, this PR isn't required to start the web server (with no settings), but it is required if we want omero-web to use any settings created with If we want this to work without |
@joshmoore Could you remove the exclude flag above? Thanks. |
@will-moore done |
This caused the build to fail today since |
I think it would be clearer to indicate this is an error e.g. prefix with Looks like other plugins that should check for
OMERO.web starts, but it's using Does each plugin ( |
@manics : can you explain what you meant here? I missed it last time around.
I imagine the logic here can become a decorator that gets applied to the multiple plugins (much like #77) I'd propose getting @manics' |
It's the equivalent of requiring |
Co-Authored-By: Josh Moore <j.a.moore@dundee.ac.uk>
This enforces setting
OMERODIR
so we don't end up with config etc in a different place foromero-py
vvomero-web
.To test, pip install this branch... and omero-web from ome/omero-web#85