Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omero.client ensure args is not None #149

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

manics
Copy link
Member

@manics manics commented Dec 16, 2019

c = omero.client('wss://idr.openmicroscopy.org/omero-ws') should work instead of throwing an Exception

@jburel
Copy link
Member

jburel commented Dec 17, 2019

Without this PR:
client = omero.client('ws://idr.openmicroscopy.org/omero-ws') or client = omero.client(host='ws://idr.openmicroscopy.org/omero-ws') will throw

ModuleNotFoundError: No module named 'omero_ext.path'

With this PR:
client = omero.client(host='ws://idr.openmicroscopy.org/omero-ws') or client = omero.client('ws://idr.openmicroscopy.org/omero-ws') do not throw.

This used to work on early dev version so this should be included in the coming 5.6 release
This prevents the usage of web socket (e.g. mybinder usage, demo scheduled 23/01)

@joshmoore
Copy link
Member

ModuleNotFoundError: No module named 'omero_ext.path'

I'm unsure how this would be related. For me, this suggests that something is out of sync, since this has been fixed separately.

@jburel
Copy link
Member

jburel commented Dec 17, 2019

Sorry I was not on master when I first run the command
The error without the PR is

>>> client = omero.client(host='ws://idr.openmicroscopy.org/omero-ws')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jmarie/Documents/git-repo/omero-py/target/omero/__init__.py", line 67, in client
    return omero.clients.BaseClient(*args, **kwargs)
  File "/Users/jmarie/Documents/git-repo/omero-py/target/omero/clients.py", line 134, in __init__
    args.append(self._get_endpoint_from_hosturl(hosturl))
AttributeError: 'NoneType' object has no attribute 'append'

@jburel
Copy link
Member

jburel commented Dec 17, 2019

Tested in notebook too AttributeError: 'NoneType' object has no attribute 'append'
with dev9
Regression between dev4 and dev9

@jburel jburel merged commit e24f36f into ome:master Dec 17, 2019
@manics manics deleted the omero-client-args-none branch December 17, 2019 13:17
@joshmoore joshmoore added this to the 5.6.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants