-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tables: call delete callback #152
Conversation
In testing the table closing logic for 5.5.1, I set up a tight loop to create, delete, and close a table. At 10000 servants it failed because the callbacks were not being cleaned up. This adds a try/finally block in order to do so. Two things to note: 1. Making use of client.submit() is not possible since we only have a ServiceFactoryPrx 2. I don't believe the nulling of the file_obj was appropriate since that's part of the close logic transferred from: ome/openmicroscopy#6082
Using this test script against my local server, I hit the same exception at the same point without and with this PR: testtables.py
Exception
|
@will-moore : the second opened table isn't closed:
patch against docker-example-omero for testing
|
OK, with that Exception
|
@will-moore : I've just re-run against merge-ci and am now beyond 10000. Is there any chance that the tables server or similar hadn't been restarted after you moved to |
More than a chance. A certainty! I'll try again... |
I'm now up to 12138...12139... ;) |
Do I just need to restart the server, or something else more Tables-specific? |
Your equivalent of
should suffice. |
Locally I don't quite reach 10,000 without this PR, will know tomorrow how I do with it. |
With this PR,
|
In testing the table closing logic for 5.5.1, I set up a tight loop to
create, delete, and close a table. At 10000 servants it failed because
the callbacks were not being cleaned up. This adds a try/finally block
in order to do so. Two things to note:
ServiceFactoryPrx
that's part of the close logic
transferred from: ome/openmicroscopy#6082