-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blitz gateway unit tests #17
Conversation
@joshmoore Not sure if this travis failure is due to this PR or something else changing?
|
I don't know either. I ran into it late yesterday while comparing the py27 and py36 tests. |
Otherwise, tests look generally good. Don't know if they will cover all the edge cases but who does... Do you have an example of what would make one of these tests fail? |
Changing logic of This causes 2 tests to fail since they expect unicode:
Removing
|
I fixed this in my py3 branch: d0ddc7e I'll cherry-pick it here and see if we can go green. |
The previous method seemed to have edge cases that led to failures based on the ordering of the parameters.
@will-moore : can you take a look at the last commit? If you're happy with it, I'd say let's get this in. (As far as I could tell |
Looks good, thanks |
Tests that some BlitzGateway Object methods return unicode and some return string.
See https://docs.openmicroscopy.org/omero/5.5.1/developers/PythonBlitzGateway.html#unicode
For a deeper discussion of Unicode handling in BlitzGateway, see ome/openmicroscopy#5400
Tests
BlitzObjectWrapper.__getattr__
returning unicode strings, enums, values/units and wrapper objects.NB: Tests pass with the current behaviour of the BlitzGateway, with some methods returning strings and some returning unicode. With Python3, that should all go away ;).