Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show-uuid option to sessions who #174

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

chris-allan
Copy link
Member

Adds a --show-uuid option to sessions who

@jburel
Copy link
Member

jburel commented Jan 27, 2020

I noticed that the info was available in the deprecated method omero admin sessionlist but not in the recommended method omero sessions who when reviewing some of @mtbc work.
We discussed adding it later on.
Thanks

Edit: omero sessions list replaced by the correct command omero admin sessionlist

@chris-allan
Copy link
Member Author

Thanks, @jburel.

sessions list applies to sessions visible to the OMERO CLI whereas sessions who is querying the server for all the active sessions. Not sure what you mean by deprecated.

@jburel
Copy link
Member

jburel commented Jan 27, 2020

apologies I meant omero admin sessionlist

@chris-allan
Copy link
Member Author

Anything else from omero admin sessionlist we want to bring over?

/cc @joshmoore, @mtbc, @manics

@jburel
Copy link
Member

jburel commented Jan 27, 2020

Looking at the field: the id was the only one missing
node | session | started | owner | agent | notes
notes indicate if it the current session but this is now indicated using *

@chris-allan
Copy link
Member Author

I guess just node? Not sure that's important information at all. Maybe in a case where there are multiple nodes off the same database? Seems like a big edge case that while theoretically possible is almost never a reality.

@chris-allan
Copy link
Member Author

@jburel: Can we get this merged or is there something else we need to do?

@jburel
Copy link
Member

jburel commented Feb 13, 2020

Thanks for the reminder. I forgot about it while on the road.
Merging so it can be included in the coming release. @manics will re-run the script for changelog

@jburel jburel merged commit 8e46db1 into ome:master Feb 13, 2020
@joshmoore joshmoore added this to the 5.6.1 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants