Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin diagnostics: show BF (and optionally other) jar versions #188

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

manics
Copy link
Member

@manics manics commented Feb 26, 2020

What this PR does

Displays some jar manifest information for the Bio-Formats jars.

IDR/deployment#168 replaces the bundled BF jars with a custom version. Since development versions may be used it'd be useful to check the versions if problems occur.

Testing this PR

$ bin/omero admin diagnostics

...

Jar:        lib/server/formats-api.jar     Bio-Formats API      6.3.1   13 December 2019        e355a853c5768721711cb9b29c3a27561539c4e4
Jar:        lib/server/formats-bsd.jar     BSD Bio-Formats readers and writers 6.3.1    13 December 2019        e355a853c5768721711cb9b29c3a27561539c4e4
Jar:        lib/server/formats-gpl.jar     Bio-Formats library  6.3.1   13 December 2019        e355a853c5768721711cb9b29c3a27561539c4e4
$ bin/omero admin diagnostics --all-jars

Recursively find and show info for all *.jar

Ported from ome/openmicroscopy#6093

@manics
Copy link
Member Author

manics commented Apr 29, 2020

Note in the original PR there was a discussion over whether the jars should be filtered if --all-jars is passed. I don't think it should filter anything, because this is for advanced diagnostic use, and the default is to only show lib/server/formats-{api,bsd,gpl}.jar. We could add more to this default list if it's useful.

src/omero/plugins/admin.py Outdated Show resolved Hide resolved
Co-authored-by: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
@dominikl
Copy link
Member

dominikl commented May 6, 2020

Looks good, works as expected 👍
Wonder if it'll be worth to get the versions of the ome-* and omero-* jars as well in the default output, e.g.

Jar:        lib/server/ome-codecs.jar      OME Codecs	0.2.5	13 August 2019	1a8b147d5673b975e14f33d78a2be886fbaf0e20
Jar:        lib/server/ome-common.jar      OME Common Java	6.0.4	21 October 2019	650939cfa026e33d2f38c1f56c74715dfb44b974
Jar:        lib/server/ome-jai.jar         OME JAI	0.1.0	28 June 2017	96ed34bf59f5ba3b51e3d60e342f30962a46c292
Jar:        lib/server/ome-mdbtools.jar    MDB Tools (Java port)	5.3.2	7 August 2018	68ffca2a95750cbb96f0d11785851aa4a554c0a4
Jar:        lib/server/ome-poi.jar         OME POI	5.3.3	6 August 2018	3887f4b2b21e195fa76ec4378858f6278aed5dcd
Jar:        lib/server/ome-xml.jar         OME XML library	6.0.1	9 May 2019	4d5b2e68d178de967d53100a1726b447726282cd
Jar:        lib/server/omero-blitz.jar     jar	5.5.6-SNAPSHOT		
Jar:        lib/server/omero-common.jar    jar	5.5.4-SNAPSHOT		
Jar:        lib/server/omero-gateway.jar   jar	5.6.3-SNAPSHOT		
Jar:        lib/server/omero-model.jar     jar	5.5.4-SNAPSHOT		
Jar:        lib/server/omero-renderer.jar  jar	5.5.4-SNAPSHOT		
Jar:        lib/server/omero-romio.jar     jar	5.5.4-SNAPSHOT		
Jar:        lib/server/omero-server.jar    jar	5.5.6-SNAPSHOT	

Or would that be a bit too much then?
I think the omero-server.jar definitely would make sense.

@manics
Copy link
Member Author

manics commented May 6, 2020

Done!

Jar:        lib/server/formats-api.jar     Bio-Formats API      6.3.1   13 December 2019        e355a853c5768721711cb9b29c3a27561539c4e4
Jar:        lib/server/formats-bsd.jar     BSD Bio-Formats readers and writers 6.3.1    13 December 2019        e355a853c5768721711cb9b29c3a27561539c4e4
Jar:        lib/server/formats-gpl.jar     Bio-Formats library  6.3.1   13 December 2019        e355a853c5768721711cb9b29c3a27561539c4e4
Jar:        lib/server/ome-codecs.jar      OME Codecs   0.2.5   13 August 2019 1a8b147d5673b975e14f33d78a2be886fbaf0e20
Jar:        lib/server/ome-common.jar      OME Common Java      6.0.4   21 October 2019 650939cfa026e33d2f38c1f56c74715dfb44b974
Jar:        lib/server/ome-jai.jar         OME JAI      0.1.0   28 June 2017   96ed34bf59f5ba3b51e3d60e342f30962a46c292
Jar:        lib/server/ome-mdbtools.jar    MDB Tools (Java port)        5.3.2  7 August 2018    68ffca2a95750cbb96f0d11785851aa4a554c0a4
Jar:        lib/server/ome-poi.jar         OME POI      5.3.3   6 August 2018  3887f4b2b21e195fa76ec4378858f6278aed5dcd
Jar:        lib/server/ome-xml.jar         OME XML library      6.0.1   9 May 2019      4d5b2e68d178de967d53100a1726b447726282cd
Jar:        lib/server/omero-blitz.jar     jar  5.5.5
Jar:        lib/server/omero-common.jar    jar  5.5.3
Jar:        lib/server/omero-gateway.jar   jar  5.6.2
Jar:        lib/server/omero-model.jar     jar  5.5.3
Jar:        lib/server/omero-renderer.jar  jar  5.5.3
Jar:        lib/server/omero-romio.jar     jar  5.5.3
Jar:        lib/server/omero-server.jar    jar  5.5.5

@dominikl
Copy link
Member

dominikl commented May 6, 2020

👍

@sbesson
Copy link
Member

sbesson commented Jun 16, 2020

This has been included in the daily builds for the last months and is very useful information for knowing the full state of the server. Merging for inclusion in omero-py 5.7.0

@sbesson sbesson merged commit 4a659a2 into ome:master Jun 16, 2020
@sbesson sbesson added this to the 5.7.0 milestone Jun 16, 2020
@manics manics deleted the diagnostics-jars branch June 16, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants