Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: require pywin32 #203

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Windows: require pywin32 #203

merged 2 commits into from
Apr 14, 2020

Conversation

manics
Copy link
Member

@manics manics commented Mar 30, 2020

Closes #201

Tested by running pip install https://github.com/manics/omero-py/archive/pywin32.zip on Windows with the zeroc-ice36-python testing package.

@joshmoore
Copy link
Member

Now green after a travis restart.

@@ -19,7 +19,7 @@ deps =
restructuredtext-lint
py36: https://github.com/ome/zeroc-ice-py-manylinux/releases/download/0.2.0/zeroc_ice-3.6.5-cp36-cp36m-manylinux2010_x86_64.whl
py37: zeroc-ice
py37-win: pypiwin32
py37-win: pywin32
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshmoore
Copy link
Member

Thanks, @manics

@joshmoore joshmoore merged commit c4855ab into ome:master Apr 14, 2020
@manics manics deleted the pywin32 branch April 14, 2020 16:18
@sbesson sbesson added this to the 5.6.3 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are windows specific python imports necessary?
3 participants