Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore owner when checking omero.data.dir is accessible #208

Merged
merged 2 commits into from
May 1, 2020

Conversation

manics
Copy link
Member

@manics manics commented Apr 21, 2020

What this PR does

The owner/permissions check on the OMERO data dir is too strict, for example it will fail if owned by root even if it is group accessible.

Testing this PR

  1. Create a new OMERO data dir
  2. Make it owned by root
  3. Change the group of the data dir to one that the user that will be running OMERO.server is a member of
  4. Make the OMERO data dir group readable/writeable
  5. Start the server and it should work!

Related reading


Ported from ome/openmicroscopy#5884

@mtbc
Copy link
Member

mtbc commented Apr 22, 2020

$ omero config get omero.data.dir
/home/mtbc/var/omero/
$ ls -ld /home/mtbc/var/omero/
drwxrwxr-x 2 root mtbc 4096 Apr 22 11:03 /home/mtbc/var/omero/
$ ls /home/mtbc/var/omero/
$ omero admin start
FATAL: OMERO directory which needs to be writeable belongs to root: /home/mtbc/var/omero/
Please use "chown -R NEWUSER /home/mtbc/var/omero/" and run as then run /tmp/omero/bin/omero as NEWUSER
$ pip install -U /tmp/omero-py-5.6.3.dev0.tar.gz 
...
Successfully installed omero-py-5.6.2
$ omero admin start
Creating /tmp/OMERO.server-5.6.0-162-891359e-ice36-b418/var/master
Initializing /tmp/OMERO.server-5.6.0-162-891359e-ice36-b418/var/log
Creating /tmp/OMERO.server-5.6.0-162-891359e-ice36-b418/var/registry
No descriptor given. Using etc/grid/default.xml
Waiting on startup. Use CTRL-C to exit
$ ls -l /home/mtbc/var/omero/
total 16
drwxr-xr-x 2 mtbc mtbc 4096 Apr 22 11:27 BioFormatsCache
drwxr-xr-x 2 mtbc mtbc 4096 Apr 22 11:28 Files
drwxr-xr-x 2 mtbc mtbc 4096 Apr 22 11:27 FullText
drwxr-xr-x 3 mtbc mtbc 4096 Apr 22 11:28 ManagedRepository
$ 

Import, web, etc. all work fine.

@joshmoore joshmoore merged commit d1c6071 into ome:master May 1, 2020
@sbesson sbesson added this to the 5.6.3 milestone Jun 9, 2020
@manics manics deleted the openmicroscopy-5884 branch July 20, 2020 13:39
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-helm-charts/40444/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants