Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert HTTP request JSON content from bytes to string. #213

Merged
merged 1 commit into from
May 13, 2020
Merged

Convert HTTP request JSON content from bytes to string. #213

merged 1 commit into from
May 13, 2020

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented May 12, 2020

Fixes ome/omero-cli-render#39 by handling Python 3.5's,

TypeError: the JSON object must be str, not 'bytes'

@joshmoore
Copy link
Member

Aha! Thanks, @mtbc.

@joshmoore
Copy link
Member

Python 3.6 looks to still be functioning fine. Trusting the testing of Python 3.5 to Mark himself.

@joshmoore joshmoore merged commit cd9e994 into ome:master May 13, 2020
@mtbc mtbc deleted the Python-3.5-JSON branch May 13, 2020 10:19
@mtbc
Copy link
Member Author

mtbc commented May 13, 2020

Thank you. Been wondering if it's worth reviewing,

omero-python-superbuild$ git grep --recurse-submodule json.loads

@joshmoore
Copy link
Member

+71 hits under https://github.com/search?q=org%3Aome+json.loads&type=Code

@sbesson sbesson added this to the 5.6.3 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Reading JSON mysteriously fails
3 participants
@mtbc @joshmoore @sbesson