Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if omero.db.poolsize is not set. #218

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Jun 4, 2020

Fixes ome/omero-server#84 by printing the suggested message during omero admin start if omero.db.poolsize has not been configured.

@joshmoore
Copy link
Member

In general, 💯

However, for me this prints out as:

(omero) /opt/omero-py $omero admin start
WARNING: Your server has not been configured for production use. See https://docs.openmicroscopy.org/omero/latest/sysadmins/server-performance.html?highlight=poolsize for more information.
No descriptor given. Using etc/grid/default.xml
Waiting on startup. Use CTRL-C to exit

I wonder if there won't be other similar items to check for (certificates?) in which case we might not want an entire block printed at the top.

@joshmoore
Copy link
Member

NB: I could see getting a quick release with this included.

@mtbc
Copy link
Member Author

mtbc commented Jun 8, 2020

Would it be better differently formatted, or maybe printed later?

@joshmoore
Copy link
Member

For the moment, I think having at the top is fine. I'd just make it blockier.

@mtbc
Copy link
Member Author

mtbc commented Jun 8, 2020

Now updated to:

WARNING: Your server has not been configured for production use.
See https://docs.openmicroscopy.org/omero/latest/sysadmins/server-performance.html?highlight=poolsize
for more information.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(venv) sbesson@ls30630:OMERO.server-5.6.0-191-6fd2072-ice36-b466 $ omero admin start
WARNING: Your server has not been configured for production use.
See https://docs.openmicroscopy.org/omero/latest/sysadmins/server-performance.html?highlight=poolsize
for more information.
No descriptor given. Using etc/grid/default.xml
Waiting on startup. Use CTRL-C to exit

Overall, this feels like our best strategy for displaying useful hardening warnings at the level of the admin start command. I will look into releasing a patch release of omero-py.

@sbesson sbesson merged commit b75dd0c into ome:master Jun 9, 2020
@mtbc mtbc deleted the poolsize-warning branch June 9, 2020 09:45
@sbesson sbesson added this to the 5.6.3 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if poolsize is not set
3 participants