-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix logging attribute error #226
Conversation
I'd err on the side of ditching. This class should really have no concept of |
k, happy to convert to a warn or raise. just let me know. |
Let's go with a warn and get it released, then I can follow up with the rest. |
k, do you want the formatted traceback in the warning? EDIT: updated with a simple warning. let me know if you want specific info in there |
Sorry for being a pain, @tlambert03, but can we go back to 2d34519 and:
|
This reverts commit ebc750e.
ok have another look at your convenience. if you also wanted the |
Awesome, thank you!
Nah. That should have never happened. 👍 |
one possible solution that fixes #225 but still lets you log from
self.ctx
if you want. Or just let me know if you want to ditch self.ctx altogether.