-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OS specific application directories instead of ~/omero #242
Conversation
Revert potentially breaking changes to get_omero_userdir Partial revert of 0f0d44e You can enable appdirs for get_omero_userdir by setting OMERO_USERDIR="" as opposed to unset
if the user wants to test the new feature, anything stores in the current selected location will be not be moved since there is no migration is offered, maybe the doc should indicate that. |
Done. A bit of googling found https://github.com/harawata/appdirs |
insight issue created ome/omero-insight#160 Thanks for the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question for everyone re: OMERO.cli
. Otherwise, seems straight-forward enough:
bash-4.2$ .venv3/bin/python -m "omero.util.temp_files" dir
/home/omero/omero/tmp/omero_omero/2432
bash-4.2$ OMERO_USERDIR="" .venv3/bin/python -m "omero.util.temp_files" dir
/home/omero/.local/share/OMERO.cli/5/tmp/omero_omero/2434
Co-authored-by: Sébastien Besson <seb.besson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 can certainly live with the use of "OMERO.py" for the moment which will at least cover the napari use case. I don't know of anyone who has made use of those files from Java.
Hi all, especially @manics and @sbesson I'd like to point out that (if I understood correctly) with the changes planned for 6.0.0 in At least I haven't found a way to influence appdirs choice on the path, e.g. through an environment variable. This might sound esoteric, but it's affecting me in hrm-omero as the way the code usually gets called on an HRM installation is through the system user running the web server (e.g. Would it be possible to have an optional way to influence where that stuff ends up in the file system? Cheers, |
Me again... Maybe I misunderstood the intention / plan of @manics - in case the idea is to retain the possibility of influencing the cache path by setting ❤️ |
I don't see any other changes planned for 6.0.0 that corresponds to what's in the docstring But even in that case, you can still override by setting |
Thanks @will-moore - if setting It's just that I read the "In 6.0.0 the default will change to use appdirs.user_data_dir" that the |
This is #233 rebased and modified to only use the
user_cache_dir
property.get_omero_userdir()
is unchanged (still returns~/omero
) but this can be changed touser_data_dir
in 6.0.0 when breaking changes are allowed.You can enable the new behaviour for
get_omero_userdir()
by settingOMERO_USERDIR=""
(empty string, as opposed to not setting it).Related to #210 but does not fully resolve it- need to wait until the new behaviour is the default
No migration options are supported since the cache dir has not yet been released. Longer term I'm inclined not to, AFAIK at the moment sessions are the only meaningful state stored under
~/omero
, and since a major release probably implies a major release of the server and therefore a restart there's no point migrating an old session.Decisions:
5
, will be6
in future) in the directory path or not.