Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mutliple Ice TLS protocols #251

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Conversation

jburel
Copy link
Member

@jburel jburel commented Sep 10, 2020

The issue was noticed when trying to connect running server on Ubuntu20.04 or CentOS 8
It was possible to connect for example from a mac to Ubuntu20.04 server but not possible to connect to Ubuntu20.04 to Ubuntu20.04 server. See https://travis-ci.org/github/ome/omero-install/jobs/725545346
This PR adds support for multiple protocols

see #250

@mtbc
Copy link
Member

mtbc commented Sep 10, 2020

👍 With this (and maybe omero-certificates) we also shouldn't have to fiddle with /etc/ssl/openssl.cnf for the Debian 10 installation.

@manics
Copy link
Member

manics commented Sep 10, 2020

I think you'll still need omero-certificates on the server side, but hopefully no other server or client config will be required

@manics manics changed the title add support for mutliple protocols Add support for mutliple Ice TLS protocols Sep 10, 2020
@manics
Copy link
Member

manics commented Sep 10, 2020

I've edited the title so it can go straight into a changelog

@jburel
Copy link
Member Author

jburel commented Sep 10, 2020

@mtbc I did not notice problem with debian 10 docker image

@mtbc
Copy link
Member

mtbc commented Sep 10, 2020

@jburel
Copy link
Member Author

jburel commented Sep 10, 2020

I forgot about that! This is done in the docker image that's true

@manics
Copy link
Member

manics commented Sep 10, 2020

So.... we need another docs release?

@jburel
Copy link
Member Author

jburel commented Sep 10, 2020

We will need a doc release regardless
cf. ome/omero-install#244

@mtbc
Copy link
Member

mtbc commented Sep 11, 2020

To get the latest commit I did,

pip install -U https://codeload.github.com/jburel/omero-py/zip/ice_protocols

Together with omero-certificates this lets me log in from CLI but not to import,

2020-09-11 09:55:08,093 1144       [      main] INFO       ome.formats.OMEROMetadataStoreClient - Attempting initial SSL connection to 127.0.0.1:4064
2020-09-11 09:55:08,413 1464       [      main] ERROR  formats.importer.cli.CommandLineImporter - Error during import process.
Ice.SecurityException: javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version

My system is a weird mix of stuff so I wouldn't read too much into that, my point is more that: whatever testing we do for this kind of thing should probably include an import.

@jburel
Copy link
Member Author

jburel commented Sep 11, 2020

Using today's omero-py build
https://travis-ci.org/github/ome/omero-install/builds/726206712

I will add an import to the testing process via travis

@manics
Copy link
Member

manics commented Sep 15, 2020

No objections so merging

@manics manics merged commit b4ec7d7 into ome:master Sep 15, 2020
manics added a commit to manics-archive/omero-py that referenced this pull request Sep 15, 2020
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-import-error-ice-securityexception-javax-net-ssl-sslhandshakeexception-no-appropriate-protocol-again/52154/17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants