-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust how --include and --exclude are presented as options. #252
Conversation
@@ -2017,10 +2016,12 @@ def _configure(self, parser): | |||
self._add_wait(parser, default=-1) | |||
parser.add_argument( | |||
"--include", | |||
help="Modifies the given option by including a list of classes") | |||
help="Specify kinds of object to include", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous help implies a "list of classes", this implies only one. Which is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if args.include:
inc = args.include.split(",")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"kinds" implies multiple, surely?
suggested by @joshmoore
For testing one can adjust the |
Co-authored-by: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
Mirrors commends on ome/omero-cli-duplicate#12 given those were adapted from these.