Adjust how --include and --exclude are presented as options. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
reviewed
Sep 14, 2020
| @@ -2017,10 +2016,12 @@ def _configure(self, parser): | |||
| self._add_wait(parser, default=-1) | |||
| parser.add_argument( | |||
| "--include", | |||
| help="Modifies the given option by including a list of classes") | |||
| help="Specify kinds of object to include", | |||
There was a problem hiding this comment.
The previous help implies a "list of classes", this implies only one. Which is correct?
There was a problem hiding this comment.
if args.include:
inc = args.include.split(",")There was a problem hiding this comment.
"kinds" implies multiple, surely?
suggested by @joshmoore
|
For testing one can adjust the |
joshmoore
reviewed
Sep 16, 2020
Co-authored-by: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors commends on ome/omero-cli-duplicate#12 given those were adapted from these.