Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test: check stderr for output #260

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

manics
Copy link
Member

@manics manics commented Oct 1, 2020

logback.xml is bundled in OMERO.java 5.6.3+, which redirects the output expected by the test

logback.xml is bundled in OMERO.java 5.6.3+, which redirects the output expected by the test
@manics manics mentioned this pull request Oct 1, 2020
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using omero-py bundled with the server,

[sbesson@ome-demoserver ~]$ /opt/omero/server/OMERO.server/bin/omero import -f -l no_fakes.txt test.fake --file ~/out --errs ~/err
[sbesson@ome-demoserver ~]$ cat ~/out 
[sbesson@ome-demoserver ~]$ cat ~/err
2020-10-01 14:41:21,051 274        [      main] INFO          ome.formats.importer.ImportConfig - OMERO.blitz Version: 5.5.7
2020-10-01 14:41:21,068 291        [      main] INFO          ome.formats.importer.ImportConfig - Bioformats version: 6.5.1 revision: 6f50e4d52c9d96112635fd8b2dde737f31041cf0 date: 7 July 2020
2020-10-01 14:41:21,104 327        [      main] INFO   formats.importer.cli.CommandLineImporter - Log levels -- Bio-Formats: ERROR OMERO.importer: INFO
2020-10-01 14:41:21,405 628        [      main] INFO      ome.formats.importer.ImportCandidates - Depth: 4 Metadata Level: MINIMUM
2020-10-01 14:41:21,418 641        [      main] INFO      ome.formats.importer.ImportCandidates - 1 file(s) parsed into 0 group(s) with 1 call(s) to setId in 10ms. (13ms total) [1 unknowns]

i.e. the parsed into line is sent to the stderr as one should expect.
Thanks for correcting this (and fixing the logging)

@sbesson sbesson merged commit 2e06457 into ome:master Oct 1, 2020
@manics manics deleted the fix-test branch October 1, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants