-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roi utils zero division fix #278
Conversation
I drew a line on https://outreach.openmicroscopy.org/webclient/?show=image-9539 (trainer-1) |
@jburel I realise that the error I got from image: https://outreach.openmicroscopy.org/webclient/?show=image-11110 was actually due to the PolyLine, since we try to calculate the Plot Profile for each section in a PolyLine, and there are horizontal lines within that PolyLine. So, you will see the error with this image. When you try to draw a "horizontal" line in iviewer, it's almost impossible since it doesn't snap to integer pixel values. The Y coordinates of the lines you drew are shown in the iviewer as "72.0" but are actually saved as:
I used a script to add horizontal line to that image https://outreach.openmicroscopy.org/webclient/?show=image-9539 so that you will see the error with that image now. |
I managed to reproduce the error against outreach now |
Tests added in ome/openmicroscopy#6264 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM. I checked omero-py and omero-web for other uses of atan+old_div and didn't find any.
This fixes an error I saw on outreach server during today's training (see below).
To test:
Should run without an error and generate a csv file.