Bug: obj update strips newlines
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex used for capturing the string after the = symbol currently stops at the first newline. This passes `re` flags to allow capturing the multiline. More tests are needed. see: https://forum.image.sc/t/line-breaks-in-descriptions-via-cli/49236/4
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/line-breaks-in-descriptions-via-cli/49236/6 |
joshmoore
added a commit
to joshmoore/openmicroscopy
that referenced
this pull request
Feb 24, 2021
|
Tested the two commands suggested in ome/openmicroscopy#6265 against a CI server with this fix included. Everything works as expected and multi-line descriptions render as multi-line. The Otherwise LGTM |
sbesson
approved these changes
Feb 26, 2021
|
Yeah, it'll be dependent on someone's shell, etc etc. |
|
Tested locally. 👍 |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex used for capturing the string after the
= symbol currently stops at the first newline. This
passes
reflags to allow capturing the multiline.More tests are needed.
see: https://forum.image.sc/t/line-breaks-in-descriptions-via-cli/49236/4