-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update omero/gateway/__init__.py #293
Conversation
Add missing key= to the sort expression The UnicodeType in python3 does not exist. This fixes the code for python3 as the omero_type function will create an rstring from the string type. If this is python2.7 a unicode string will still be a unicode string after formatting as ('%s%%' % start) and the omero_type function will correctly encode it.
Thanks, @aherbert. I've added a label so it should be included in automated testing tomorrow. |
Could you provide some testing instructions for this @aherbert ? |
From an OMERO cli environment enter this from a python terminal: import omero
from omero.gateway import BlitzGateway
# Should be an admin or someone who can see a lot of users
conn = BlitzGateway('user', 'password', host='whereever.com')
conn.connect()
for e in conn.findExperimenters():
print(e.id, e.getFullName())
for e in conn.findExperimenters('root'):
print(e.id, e.getFullName()) Currently the method |
@dominikl : did you have any feedback on this? |
Without this PR:
With this PR it works as expected. Good to merge 👍 |
Hi @aherbert. We've started requiring contributors to sign a Contributor License Agreement (CLA). Could you download the CLA form, fill and sign it and return it by email to contributors@openmicroscopy.org. Thanks again for the contribution! |
@joshmoore CLA all done. |
Thanks! |
Add missing
key=
to the sort expression lambda