Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import --fetch-jars: allow direct link #303

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

joshmoore
Copy link
Member

see: https://github.com/ome/omero-py/pull/162/files#r494801779

allows usage such as:

omero import --fetch-jars https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/lastSuccessfulBuild/artifact/src/target/OMERO.java-5.6.3-150-65ec95d-ice36-b940.zip

Useful for testing:

omero import -f /tmp/a.ome.zarr/.zgroup

with ome/openmicroscopy#6292

@joshmoore joshmoore mentioned this pull request Sep 7, 2021
src/omero/plugins/import.py Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member Author

Testable today with:

omero import --fetch-jars https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/lastSuccessfulBuild/artifact/src/target/OMERO.java-5.6.3-126-105026f-ice36-b948.zip

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally works as expected although I was unable to completely test the Zarr import workflow as ome/openmicroscopy#6292 is not included yet.

The code change is minimal and supplements the supported x.y.z and latest values of --fetch-jars with full URLs.

Two minor suggestions:

  • the argument of def download_omero_java(self, version): could be renamed e.g. version_or_url to reflect the changes
  • the help string for the --fetch-jars could be updated to document the support of URLs

Would you propose to get shipped in a release asap? If so, minor or patch version increment?

@joshmoore
Copy link
Member Author

I'll get those changes pushed, but I assume a) it can be a patch release and b) it's no rush until Zarr is included as you mention.

@joshmoore
Copy link
Member Author

A minor rabbit hole here in the readability of long argument descriptions..

@joshmoore
Copy link
Member Author

Updated, @sbesson

@sbesson sbesson merged commit 55b4571 into ome:master Dec 9, 2021
@joshmoore joshmoore deleted the fetch-merge-jars branch July 4, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants