-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import --fetch-jars: allow direct link #303
Conversation
Testable today with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally works as expected although I was unable to completely test the Zarr import workflow as ome/openmicroscopy#6292 is not included yet.
The code change is minimal and supplements the supported x.y.z
and latest
values of --fetch-jars
with full URLs.
Two minor suggestions:
- the argument of
def download_omero_java(self, version):
could be renamed e.g.version_or_url
to reflect the changes - the help string for the
--fetch-jars
could be updated to document the support of URLs
Would you propose to get shipped in a release asap? If so, minor or patch version increment?
I'll get those changes pushed, but I assume a) it can be a patch release and b) it's no rush until Zarr is included as you mention. |
A minor rabbit hole here in the readability of long argument descriptions.. |
Updated, @sbesson |
see: https://github.com/ome/omero-py/pull/162/files#r494801779
allows usage such as:
Useful for testing:
with ome/openmicroscopy#6292