Implementation for DatasetColumn #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @muhanadz. 👍 for getting a test in ome/openmicroscopy, both at that location but perhaps more generally with the use-case that you're covering. The test can still go green even before this PR is merged since all PRs are merged together daily for testing purposes: |
|
Thanks for slogging it through, @muhanadz! ome/openmicroscopy#6300 is green and in. ❤️ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation for
DatasetColumnwhich was imported fromomero.gridinomero metadatabut was never implemented.DatasetColumnheader defined here.This PR hopes to start the process of supporting dataset IDs as column type (currently only dataset names are supported).
omero metadataready to handleDatasetColumnhereMight need to add
DatasetColumntest case here once merged.