Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode script stdout/stderr before printing #310

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

jmuhlich
Copy link
Contributor

@jmuhlich jmuhlich commented Dec 6, 2021

This change fixes a bytes-str concatenation issue in omero script launch output under Python 3 that caused the stdout/stderr lines to be printed as their repr. Output that previously looked like this:

	* b'Image:1 : Processing...\n--------------------\n'

Now looks correct:

	* Image:1 : Processing...
	* --------------------
	* 

(Tracebacks are now readable again too)

@sbesson sbesson added the include label Dec 7, 2021
@will-moore
Copy link
Member

Thanks for the fix. Working fine for me. 👍

@joshmoore joshmoore merged commit ceddc2b into ome:master Dec 8, 2021
@sbesson
Copy link
Member

sbesson commented Dec 8, 2021

Should we get this into a quick 5.10.2 release?

@joshmoore
Copy link
Member

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants