Config output exclude versions #312
Conversation
src/omero/install/config_parser.py
Outdated
| @@ -173,6 +173,8 @@ def get_reference(self): | |||
|
|
|||
| STOP = "### END" | |||
|
|
|||
| EXCLUDED_VERSION = ["omero.version"] | |||
There was a problem hiding this comment.
What is the different between this new API and BLACK_LIST defined four lines above. Would appending omero.version to the set suffice to exclude this property from being parsed?
(NB: as per our recent review, this might be the occasion to do s/BLACK_LIST/EXCLUDE_LIST
There was a problem hiding this comment.
I did not want to confuse things but happy to revisit it
There was a problem hiding this comment.
If the two exclusion lists achieve different goals, it's fine to introduce new logic. But even then it might be useful to know and document in which context each list should be used when excluding new properties.
There was a problem hiding this comment.
Looking at it closely, they have similar goals so I have added to the list
I have renamed the list. I have not renamed the method but happy to do so
There was a problem hiding this comment.
Yes. Let's keep things contained and get this out as a patch release. I will open a follow-up PR to rename the method and deprecate the old one
Exclude keys with
versionfrom the output of theconfig parsecommandcc @sbesson @joshmoore