Also pass omero.db.properties and omero.db.url to reindex

[chris-allan]

Under certain conditions, in particular those where a specific sslmode ¹ is required, omero.db.properties is an essential property that must be provided for the reindexing code to be able to communicate with the database.

Footnotes

1. https://jdbc.postgresql.org/documentation/head/ssl-client.html ↩

[chris-allan]

@stick will validate this on our side. We have a user who has this requirement in production (sslmode=require) and currently can't reindex because of it.

Couple other thoughts which are possibly beyond the scope of this PR:

1. If a user is making use of omero.db.url ¹ instead of the individual properties reindexing won't work
2. If omero.db.pass is not being provided on the command line I'm not sure how reindexing works if a password other than omero is being used (@stick and I will validate this)

Footnotes

1. https://docs.openmicroscopy.org/omero/5.6.4/sysadmins/config.html#omero-db-url ↩

[stick]

tested internally and all seems to work as desired.
various db.properties are honored as expected.

[chris-allan]

Also validated that omero.db.pass is provided via the JAVA_OPTS environment variable so we're all good there.

[joshmoore]

👍

[sbesson]

Also tested omero admin reindex with a default server setting and confirmed the behavior is unafffected. Overall, the additions are sensible and this should be ready to include in the upcoming OMERO.py release. Is there a timeline for having this fix released from your side?

[chris-allan]

Is there a timeline for having this fix released from your side?

None right now. We managed to work around the problem by forcing TLS 1.2 (which is incidentally what the user really wanted anyway).

[will-moore]

FYI: this is now in the recent 5.12.0 release of omero-py