-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also pass omero.db.properties and omero.db.url to reindex #329
Conversation
@stick will validate this on our side. We have a user who has this requirement in production ( Couple other thoughts which are possibly beyond the scope of this PR:
Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested internally and all seems to work as desired.
various db.properties are honored as expected.
Also validated that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tested omero admin reindex
with a default server setting and confirmed the behavior is unafffected. Overall, the additions are sensible and this should be ready to include in the upcoming OMERO.py release. Is there a timeline for having this fix released from your side?
None right now. We managed to work around the problem by forcing TLS 1.2 (which is incidentally what the user really wanted anyway). |
FYI: this is now in the recent 5.12.0 release of |
Under certain conditions, in particular those where a specific
sslmode
1 is required,omero.db.properties
is an essential property that must be provided for the reindexing code to be able to communicate with the database.Footnotes
https://jdbc.postgresql.org/documentation/head/ssl-client.html ↩