Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always report pixeldata time in the output of fs importtime #335

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Oct 3, 2022

While investigating, mismatches between the sum of the import times reported by the CLI command and the import logs, I realised the time for completing this step is being skipped if no rendering settings are assigned. In addition to pyramid generation, several actions are being performed including min/max calculation and pixel/series assignment.

Testing

Without this PR, import a file e.g. a fake image/plate with and without setting the thumbnails

omero import "test&plateRows=4&plateCols=4.fake"
omero import "test&plateRows=4&plateCols=4.fake" --skip thumbnails

Then run omero fs importtime Fileset:<id> on both filesets. Without this PR the pixeldata step of the second command should be omitted from the output. With this PR included, it should be reported in both cases

While investigating, mismatches between the sum of the import times
reported by the CLI command and the import logs, I realised the time for
completing this step is being skipped if no rendering settings are
assigned. In addition to pyramid generation, several actions are being
performed including min/max calculation and pixel/series assignment.
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@sbesson
Copy link
Member Author

sbesson commented Oct 5, 2022

@jburel @joshmoore thoughts about scheduling an immediate 5.12.1 release including this bug fix or do you have other changes you would like to see included?

@joshmoore
Copy link
Member

None from me.

@jburel
Copy link
Member

jburel commented Oct 5, 2022

No other changes from my side after quickly reviewing the open PRs

@sbesson sbesson merged commit 5205ba9 into ome:master Oct 5, 2022
@sbesson sbesson deleted the importtime_pixeldata branch July 27, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants