Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omero.clients: initialize connection retry reason out of the while loop #353

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 22, 2022

Fixes #352

The logic should be unchanged by the exception shouldn't be reset to None and displayed on each retry

@sbesson sbesson changed the title Initialize connection retry reason out of the while loop omero.clients: initialize connection retry reason out of the while loop Nov 22, 2022
@jburel
Copy link
Member

jburel commented Nov 22, 2022

Including this PR in the upcoming 5.13.
I will adjust the changelog accordingly

@jburel jburel merged commit 2e78e39 into ome:master Nov 22, 2022
@sbesson sbesson deleted the retry_reason branch December 2, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Informative error reason set to None before sending to logger in clients.py
3 participants