Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Python 3.7 #368

Merged
merged 3 commits into from
Apr 17, 2023
Merged

drop Python 3.7 #368

merged 3 commits into from
Apr 17, 2023

Conversation

jburel
Copy link
Member

@jburel jburel commented Apr 6, 2023

Drop support for Python 3.7

@jburel
Copy link
Member Author

jburel commented Apr 10, 2023

hdf5 tests currently fail on windows when using Python 3.8+

@jburel
Copy link
Member Author

jburel commented Apr 17, 2023

@sbesson 9cbe240 uses the wheel produced by GS
The tests are still failing on Windows so I have not bumped to 3.8+
You approved it before my last commit (and the build was still red). Are you okay with the current state of the PR?

I will investigate the hdf issue in a follow-up PR.
Maybe an opportunity to remove our old copy of portalocker. The files stay locked leading to the failure with Python 3.8

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jburel no objections to moving forward with this PR.
On the Python 3.7/Windows front, we definitely need to look into these issues separately. Removing our vendored copy of portalocker had been already mentioned in ome/omero-web#415 (comment) during the migration to upstream concurrent-log-handler in OMERO.web.

Using upstream portalocker and deprecating omero_ext/portalocker would be valuable. From a quick code review, the main locations which will need functional review are omero config, omero admin, temporary files as well as OMERO.tables.

@jburel jburel merged commit d5ca72f into ome:master Apr 17, 2023
@jburel jburel deleted the drop_py37 branch April 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants