Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated method #408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove deprecated method #408

wants to merge 1 commit into from

Conversation

jburel
Copy link
Member

@jburel jburel commented May 1, 2024

Remove method

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API has been deprecated since OMERO 5.3.0 and is certainly scheduled for removal. Is the plan to release this in a minor version increment or a major version increment given the backwards incompatible change? Also is there a concrete driver for actioning this removal?

@jburel
Copy link
Member Author

jburel commented May 2, 2024

No real concrete driver but while working on the gateway I noticed the method marked as deprecated and the apologies linked to it so it does not make sense to keep it and I think it is more that time to remove it

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the removal of a long-deprecated method. Probably the biggest question to answer is whether this should wait until a major version increment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants