omero.HdfStorage.update: add size check on data.rowNumbers #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the omero.grid.Data passed to table.update() has rowNumbers values outside the range of rows, the implementation will raise an IndexError which will be returned as an InternalException to the client. This commit adds an initial call to self.__sizecheck(None, data.rowNumbers) which should raise an ApiUsageException with an appropriate error message in that scenario.
sbesson
force-pushed
the
table_update_outofrange
branch
from
6710f11
to
0e500ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the
omero.grid.Datapassed totable.update()has rowNumbers values outside the range of rows, the implementation will raise an IndexError which will be returned as an InternalException to the client.This commit adds an initial call to
self.__sizecheck(None, data.rowNumbers)which should raise anApiUsageExceptionwith an appropriate error message in that scenario.This scenario should be covered by the last tests introduced in ome/openmicroscopy#6412