-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build #28
Update build #28
Conversation
Latest version brings in a newer version of Django which breaks OMERO.web
Also adds optional Docker login vars to push
Seems to build and run OK (no errors). |
Ah, sorry - I wasn't on this PR branch. |
Tested with a docker-compose file that matches the description here that I will open as a separate PR. 👍 |
Beyond just using make for building a set of paired omero-web and omero-web-standalone images, this allows building within a self-contained docker-compose.yml. see: ome#28
make docker-build
should work as expected, previously the standalone image ignored the local one.This should make it easier to test OMERO.web Docker related PRs. For example ome/openmicroscopy#5948 (comment) could be tested locally by building the standalone image with a CI artifact: