Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build #28

Merged
merged 7 commits into from
May 8, 2019
Merged

Update build #28

merged 7 commits into from
May 8, 2019

Conversation

manics
Copy link
Member

@manics manics commented Apr 26, 2019

  • Fixes the Makefile so the standalone image is always built from the matching non-standalone image, e.g. make docker-build should work as expected, previously the standalone image ignored the local one.
  • Updates the test script so in future it could be used to push to Travis. At present the OMERO.web Docker release process is completely manual since automated builds don't allow multiple images.
  • Adds the django-cors-header fix from Cap version of django-cors-header deployed in IDR IDR/deployment#169

This should make it easier to test OMERO.web Docker related PRs. For example ome/openmicroscopy#5948 (comment) could be tested locally by building the standalone image with a CI artifact:

make VERSION=test REPO=test BUILDARGS="\
    --build-arg OMEGO_ADDITIONAL_ARGS=--ci=https://web-proxy.openmicroscopy.org/west-ci/ \
    --build-arg=OMERO_VERSION=OMERO-build" docker-build

docker run -d --name test-web \
    -e CONFIG_omero_web_server__list='[["eel.openmicroscopy.org", 4064, "eel"]]' \
    -e CONFIG_omero_web_debug=true \
    -p 4080:4080 \
    test/omero-web-standalone:latest

@will-moore
Copy link
Member

Seems to build and run OK (no errors). test-web seems to be running but I was expecting http://localhost:4080/ to give me something?

@will-moore
Copy link
Member

Ah, sorry - I wasn't on this PR branch.
Working fine.
Used docker run -it --rm --name test-web... to run interactively and http://localhost:4080/webclient/ is working fine, logged into eel.

@joshmoore
Copy link
Member

Tested with a docker-compose file that matches the description here that I will open as a separate PR. 👍

@joshmoore joshmoore merged commit 02f01fc into ome:master May 8, 2019
joshmoore added a commit to joshmoore/omero-web-docker that referenced this pull request May 8, 2019
Beyond just using make for building a set of paired
omero-web and omero-web-standalone images, this allows
building within a self-contained docker-compose.yml.

see: ome#28
@manics manics deleted the update-build branch May 8, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants