Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubuntu1804 #92

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Remove ubuntu1804 #92

merged 4 commits into from
Dec 8, 2023

Conversation

jburel
Copy link
Member

@jburel jburel commented Sep 5, 2023

Remove ref to ubuntu18.04

@@ -3,8 +3,6 @@ ansible/*.retry
ansible/.DS_Store
**/omeroweb-install-*
**/centos7*/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess centos7 could be removed too from gitignore

Suggested change
**/centos7*/**

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centos7 has not been removed yet

Copy link
Member

@dominikl dominikl Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok 👍 Just ignore my suggestion.

Copy link
Member

@dominikl dominikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion. Apart from that looks good to me 👍

@jburel jburel merged commit b9dd160 into ome:master Dec 8, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants