Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #6329

Merged
merged 3 commits into from
Jul 4, 2022
Merged

update dependencies #6329

merged 3 commits into from
Jul 4, 2022

Conversation

jburel
Copy link
Member

@jburel jburel commented Jun 29, 2022

This PR introduces a new job that will be run daily to check if some ome dependencies have been released.
If this is the case, the version(s) in omero.properties will be updated and a PR will be open

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptutally, this like a useful action which implements an automated version bump similar to what GitHub dependabot does for the purpose of our custom build system with multiple dependency sources.

Probably the biggest unknown is out to validate the logic. Would it be doable to extract all the update logic into a standalone script in the repository. This would allow to test the script in isolation but also for the GitHub action to consume it?

@jburel
Copy link
Member Author

jburel commented Jun 29, 2022

I have added bash script and it is used by the GHA
Note that to run locally jq will need to be installed e.g. conda install -c conda-forge jq . Also -e flag is required on MacOS

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally by changing a few of the last versions declared in omero.properties. Running the update_dependencies.sh script restores the current content of the file.

Merging and we'll monitor whether the next upstream releases are automatically picked up

@sbesson sbesson merged commit e33b497 into ome:develop Jul 4, 2022
@jburel jburel mentioned this pull request Jul 4, 2022
@jburel jburel deleted the update_dependencies branch March 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants