OMERO.web: improve the CSRF tests coverage #6419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the expected response message to include the reason Add a second integration test with a X-CSRFToken with empty value
sbesson
force-pushed
the
csrf_token_failure_message
branch
from
dde4189 to
410c732
Compare
Test empty and invalid CRSF token scenarios
sbesson
changed the title
Add test for missing CSRF cookie, empty and invalid CSRF tokens
sbesson
force-pushed
the
csrf_token_failure_message
branch
from
265dd48 to
f315a50
Compare
sbesson
changed the title
knabar
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the scope of the integration tests to match the response message changes proposed ome/omero-web#608 and cover additional CSRF protection scenarios