Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set a default port #87

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Don't set a default port #87

merged 2 commits into from
Feb 26, 2020

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented Jan 29, 2020

The connect method sets the default port to 4064 if no port is specified. That way you can't connect to websocket URL by simply...

server <- OMEROServer(host = "wss://localhost", username = "xx", password = "xx")
server <- connect(server)

...because the port will be set to 4064 by the R gateway. All the logic is already in the Java gateway, so this PR removes setting the default port in the R gateway, and above example should work.

See also #86

@dominikl dominikl changed the title Don't set a default port, the java gateway handles that. Don't set a default port Jan 29, 2020
@jburel
Copy link
Member

jburel commented Feb 25, 2020

I am having a hard time building the docker image using the dockerfile under jupyter directory

library('romero.gateway')
Error in library("romero.gateway") : 
  there is no package called ‘romero.gateway’
Execution halted

@jburel
Copy link
Member

jburel commented Feb 25, 2020

using the other dockerfile

Error in library(devtools) : there is no package called ‘devtools’
Execution halted

@jburel jburel mentioned this pull request Feb 25, 2020
@jburel
Copy link
Member

jburel commented Feb 25, 2020

I combined the changes in #88 and ran the adjusted notebook
I was able to connect with and without websocket

@jburel
Copy link
Member

jburel commented Feb 25, 2020

#88 should be merged first otherwise travis will fail

@jburel jburel merged commit 7c6fd41 into ome:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants