fix: fetches nssf uri even if already cached #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thakurajayL
reviewed
Nov 23, 2023
| } | ||
| // TODO: Set a timeout of NSSF Selection or will starvation here | ||
| for { | ||
| if err := SearchNssfNSSelectionInstance(ue, nrfUri, models.NfType_NSSF, |
There was a problem hiding this comment.
Something to be done if not already available. NRF results are cached internally. We should see if we can cache this result as well. that code is part of NRF repo. It helps in performance. Also upon any failure in NRF cache should be refreshed.
thakurajayL
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so that the
SelectSmffunction retrievesSearchNssfNSSelectionInstanceeven if there already is a stored value for the NSSF URI. This fixes an issue where the NSSF uri was only stored once on AMF startup and never retrieved again. This was a problem in cases where the NSSF crashed and its IP changed.Fixes #133