-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Deregistration Notification Implementation #214
Conversation
|
@@ -161,7 +161,6 @@ func (ran *AmfRan) SetRanId(ranNodeId *ngapType.GlobalRANNodeID) { | |||
if ranId.GNbId != nil { | |||
ran.GnbId += ranId.GNbId.GNBValue | |||
} | |||
AMF_Self().AmfRanPool.Store(ran.GnbId, ran) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please tell us why this is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The map 'amfranpool' was populated with two entries for single NG connection.
This line of code adds one extra entry to amfranpool for the same NG connection.
Therefore, two paging messages are send by AMF.
Furthermore, this extra line of code is found in omec-project/amf repository but not in free5gc/amf repository (https://github.com/free5gc/amf/blob/main/internal/context/amf_ran.go).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share where is the other entry added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Attaching the screenshot of the function where the other entry is added.
The function 'NewAmfRan' is called in 'ngap/dispatcher.go' (https://github.com/omec-project/amf/blob/master/ngap/dispatcher.go#L116).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This PR involves