Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to disable Kafka #263

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Support to disable Kafka #263

merged 1 commit into from
Jun 15, 2024

Conversation

thakurajayL
Copy link
Contributor

No description provided.

@gab-arrobo
Copy link
Contributor

close #262

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to effectively disable publishing of data by the amf and smf, changes need to be done in the helm charts. Does it mean that we need to expose (override) these parameters/values from the sdcore-5g-values.yaml file? Currently, it only exposes the option to deploy (or not) kafka pod regardless of what is configured in the amf and/or smf. Does any other NF use kafka? If not, what about "controlling" the deployment of kafka if and only if the amf or smf needs to publish topics/data?

context/amf_ran.go Show resolved Hide resolved
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo
Copy link
Contributor

To be able to effectively disable publishing of data by the amf and smf, changes need to be done in the helm charts. Does it mean that we need to expose (override) these parameters/values from the sdcore-5g-values.yaml file? Currently, it only exposes the option to deploy (or not) kafka pod regardless of what is configured in the amf and/or smf. Does any other NF use kafka? If not, what about "controlling" the deployment of kafka if and only if the amf or smf needs to publish topics/data?

@thakurajayL, are you planning to make changes to helm charts and sdcore-5g-values.yaml to expose the option to effectively disable kafka inside the amf and smf?

@thakurajayL
Copy link
Contributor Author

To be able to effectively disable publishing of data by the amf and smf, changes need to be done in the helm charts. Does it mean that we need to expose (override) these parameters/values from the sdcore-5g-values.yaml file? Currently, it only exposes the option to deploy (or not) kafka pod regardless of what is configured in the amf and/or smf. Does any other NF use kafka? If not, what about "controlling" the deployment of kafka if and only if the amf or smf needs to publish topics/data?

@thakurajayL, are you planning to make changes to helm charts and sdcore-5g-values.yaml to expose the option to effectively disable kafka inside the amf and smf?

Its already there,
diff --git a/roles/core/templates/sdcore-5g-values.yaml b/roles/core/templates/sdcore-5g-values.yaml
index 485448c..86cfbbc 100644
--- a/roles/core/templates/sdcore-5g-values.yaml
+++ b/roles/core/templates/sdcore-5g-values.yaml
@@ -73,6 +73,8 @@ omec-control-plane:
amfcfg.conf:
configuration:
enableDBStore: true # Store AMF subscribers in the datastore

  •        kafkaInfo:
    
  •          brokerUri: ""
    

    SMF config override. Refer to Helm Charts values for more options

    smf:
    ajayonf@node0:~/aether-onramp/deps/5gc$

Let me know what else you are looking for.

@thakurajayL thakurajayL merged commit 692da71 into master Jun 15, 2024
8 checks passed
@thakurajayL thakurajayL deleted the dev-support-disable-kafka branch June 15, 2024 22:26
@gab-arrobo
Copy link
Contributor

To be able to effectively disable publishing of data by the amf and smf, changes need to be done in the helm charts. Does it mean that we need to expose (override) these parameters/values from the sdcore-5g-values.yaml file? Currently, it only exposes the option to deploy (or not) kafka pod regardless of what is configured in the amf and/or smf. Does any other NF use kafka? If not, what about "controlling" the deployment of kafka if and only if the amf or smf needs to publish topics/data?

@thakurajayL, are you planning to make changes to helm charts and sdcore-5g-values.yaml to expose the option to effectively disable kafka inside the amf and smf?

Its already there, diff --git a/roles/core/templates/sdcore-5g-values.yaml b/roles/core/templates/sdcore-5g-values.yaml index 485448c..86cfbbc 100644 --- a/roles/core/templates/sdcore-5g-values.yaml +++ b/roles/core/templates/sdcore-5g-values.yaml @@ -73,6 +73,8 @@ omec-control-plane: amfcfg.conf: configuration: enableDBStore: true # Store AMF subscribers in the datastore

  •        kafkaInfo:
    
  •          brokerUri: ""
    

    SMF config override. Refer to Helm Charts values for more options

    smf:
    ajayonf@node0:~/aether-onramp/deps/5gc$

Let me know what else you are looking for.

What I mean is the following two things:

  1. I thonk we should we expose this option in sdcore-5g-values.yaml file in OnRamp because currently, we can "disable" kafka (not deploy the kafka pod) but we can not do any change related to kafka in the amf and smf (in sdcore-5g-values.yaml.
  2. Currently we have two "parallel" options to "enable/disable" kafka in the helm charts. One is about the deployment of kafka (pod) and the other is about using kafka inside the amf and smf pods. So, I was wondering if you are planning to "unify" these two options such that the kafka pod is deployed only if the amf or smf has it enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants