Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use nrfcache from openapi repository #281

Merged

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Aug 15, 2024

This PR reduces the decrease the complexity of dependencies by using nrfcahce library from Openapi.

fix: Sove linting issues in the repository

This PR reduces the decrease the complexity of dependencies by using nrfcahce library from Openapi.

fix: Sove linting issues in the repository

Signed-off-by: gatici <gulsum.atici@canonical.com>
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. The only thing missing is to update go.mod and go.sum to remove the nrf dependency.

go.mod Outdated Show resolved Hide resolved
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from gab-arrobo August 16, 2024 07:18
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (Tested changes with OnRamp)

@gab-arrobo gab-arrobo merged commit b3ce51c into omec-project:master Aug 16, 2024
8 checks passed
@gab-arrobo
Copy link
Contributor

@gatici feel free to open a PR for a new release/tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants