NfDown Notification Handling #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vthiruveedula
commented
Jan 9, 2023
vthiruveedula
commented
- refer to the latest util/drsm 1.0.9.
- NfDownNotification handling
vthiruveedula
force-pushed
the
dev-nfinstance
branch
3 times, most recently
from
e984bb4
to
6178ead
Compare
badhrinathpa
reviewed
Jan 9, 2023
oam/routers.go
Outdated
| @@ -100,4 +102,10 @@ var routes = Routes{ | |||
| "/active-ues", | |||
| HTTPGetActiveUes, | |||
| }, | |||
| { | |||
| "Amf Instance Down Notificatication", | |||
| @@ -41,7 +43,9 @@ func InitAmfContext(context *context.AMFContext) { | |||
| config := factory.AmfConfig | |||
| logger.UtilLog.Infof("amfconfig Info: Version[%s] Description[%s]", config.Info.Version, config.Info.Description) | |||
| configuration := config.Configuration | |||
| context.NfId = uuid.New().String() | |||
| if context.NfId == "" { | |||
There was a problem hiding this comment.
what is the case when NfId wont be null ??
There was a problem hiding this comment.
Network Instance Id will be empty when the amf comes up first, so first-time NfId should be generated, later we should use the same NfId.
| logger.ConsumerLog.Errorf("Remove NF Subscription Failed Problem[%+v]", problemDetails) | ||
| } else if err != nil { | ||
| logger.ConsumerLog.Errorf("Remove NF Subscription Error[%+v]", err) | ||
| if notificationData.Event == models.NotificationEventType_DEREGISTERED { |
There was a problem hiding this comment.
why do we need this check. will the amf instance down reach here with some other event type ?
There was a problem hiding this comment.
there are two events currently, PROFILE_Changed or DEREGISTRED, so entry from the cache must be deleted only in case of DEREGISTERED
vthiruveedula
force-pushed
the
dev-nfinstance
branch
2 times, most recently
from
a9f7b59
to
2138c7b
Compare
vthiruveedula
force-pushed
the
dev-nfinstance
branch
from
2138c7b
to
9c9d6ef
Compare
|
retest please |
1. Handling NF Down Notification from NRF 2. refer new util version 1.0.9(nfinstanceid added in keepalive and chunk table) 3. removing subscription from NRF when the target NF instance is down
vthiruveedula
force-pushed
the
dev-nfinstance
branch
from
9c9d6ef
to
9fe3b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.